Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Plethora dataset #263

Merged
merged 12 commits into from
May 24, 2024
Merged

Add Plethora dataset #263

merged 12 commits into from
May 24, 2024

Conversation

anwai98
Copy link
Contributor

@anwai98 anwai98 commented May 16, 2024

This is the dataset for pleural effusion and lung segmentation in CT scans.

In addtiion, this PR addresses:

  • Adding the tcia_utils API to install tcia manifest easily. (WIP)

Looks like it's working. I will test it on the entire dataset and finalize this tomorrow.

@anwai98 anwai98 marked this pull request as ready for review May 19, 2024 06:14
@anwai98
Copy link
Contributor Author

anwai98 commented May 23, 2024

Hi @constantinpape,

As discussed, I added a new functionality which looks at the kwargs if raw_transform or label_transform are incoming, else applies resize trafo as expected. Let me know if you spot somethinng. This is good to go from my side. Thanks!

constantinpape
constantinpape reviewed May 23, 2024
View reviewed changes
torch_em/transform/raw.py Outdated Show resolved Hide resolved
torch_em/data/datasets/util.py Outdated Show resolved Hide resolved
torch_em/data/datasets/util.py Outdated Show resolved Hide resolved
@anwai98
Copy link
Contributor Author

anwai98 commented May 23, 2024 •
edited
Loading

@constantinpape Thanks for the feedback, All the mentions have been taken care of now. GTG from my side!

constantinpape
constantinpape reviewed May 24, 2024
View reviewed changes
Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some issues with Compose, but I went ahead and fixed them.

torch_em/data/datasets/util.py Outdated Show resolved Hide resolved
torch_em/data/datasets/util.py Outdated Show resolved Hide resolved
torch_em/data/datasets/util.py Outdated Show resolved Hide resolved
@constantinpape constantinpape merged commit e99d01a into constantinpape:main May 24, 2024
2 checks passed
@anwai98 anwai98 deleted the tcia-archives branch May 24, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constantinpape constantinpape constantinpape left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anwai98 @constantinpape