Add Serializer to DefaultTrainer #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FynnBe
force-pushed
the
trainer_serializer
branch
from
00759c1
to
45ade82
Compare
FynnBe
force-pushed
the
trainer_serializer
branch
from
3df476d
to
68887b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also changes the Deserializer a bit so it is more obvious how they function in combination...
I didn't want to move code too much, but maybe after this PR the DefaultTrainer could do with some clean-up, probably moving the definitions of Deserializer and Serializer closer together would be helpful.