Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

실시간 돌발 정보를 오래된 것부터 최대 10개 응답 #2

Merged
merged 2 commits into from Dec 2, 2019
Merged

실시간 돌발 정보를 오래된 것부터 최대 10개 응답 #2

merged 2 commits into from Dec 2, 2019

Conversation

cmygray
Copy link
Collaborator

@cmygray cmygray commented Nov 10, 2019

개요

서울시 실시간 돌발 정보를 열람하는 프락시 서버를 FastAPI를 사용해서 만들었습니다

변경사항

  • FastAPI 앱 추가
    • /accidents 엔드포인트 추가
    • Accident 모델 추가

테스트 방법

README를 참고하여 로컬 서버를 띄우고:

  1. /accidents 에 접속해서 응답 데이터를 확인
  2. /docs 또는 /redoc 에 접속해서 API 명세를 확인

연관이슈

#1

@cmygray cmygray added this to In progress in Staging via automation Nov 10, 2019
@cmygray cmygray self-assigned this Nov 10, 2019
@cmygray cmygray moved this from In progress to Review in progress in Staging Nov 10, 2019
@cmygray cmygray removed the request for review from constmoon November 10, 2019 13:56
@cmygray cmygray changed the title 실시간 돌발 정보를 오래된 것부터 최대 10개 응답 실시간 돌발 정보를 오래된 것부터 최대 10개 응답[WIP] Nov 10, 2019
lexifdev
lexifdev previously requested changes Nov 10, 2019
View reviewed changes
Copy link
Collaborator

@lexifdev lexifdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드는 전반적으로 좋네요. 주로 컨벤션과 일관성 관련 리뷰를 달았습니다.

backend/.env.sample Outdated Show resolved Hide resolved
backend/README.md Outdated Show resolved Hide resolved
backend/main.py Show resolved Hide resolved
backend/main.py Outdated Show resolved Hide resolved
backend/main.py Outdated Show resolved Hide resolved
backend/settings.py Show resolved Hide resolved
backend/.env.sample Show resolved Hide resolved
backend/main.py Outdated Show resolved Hide resolved
backend/parser.py Outdated Show resolved Hide resolved
@cmygray cmygray changed the title 실시간 돌발 정보를 오래된 것부터 최대 10개 응답[WIP] 실시간 돌발 정보를 오래된 것부터 최대 10개 응답 Nov 11, 2019
lexifdev
lexifdev reviewed Nov 19, 2019
View reviewed changes
Copy link
Collaborator

@lexifdev lexifdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parser() 함수명에 대해서 의견 남겨드렸어요.

lexifdev
lexifdev requested changes Nov 29, 2019
View reviewed changes
Copy link
Collaborator

@lexifdev lexifdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parser 함수명만 고치면 될 것 같아요.

@cmygray
feat(backend): 실시간 돌발 정보를 오래된 것부터 최대 10개 응답
77e9f84 
/accidents 엔드포인트 요청에 돌발 정보 데이터 응답

changes:
- (main.py): /accidents 엔드포인트와 응답 데이터 모델 작성
- (models.py): Accident 모델 정의
- (parser.py): xml 형식 문자열을 Accident 모델 구조에 맞게 파싱

Signed-off-by: cmygray <cmygray@gmail.com>
@cmygray
docs(backend): update readme
50b2b8c 
Signed-off-by: cmygray <cmygray@gmail.com>
@cmygray cmygray requested a review from lexifdev December 1, 2019 06:35
@cmygray
Copy link
Collaborator Author

cmygray commented Dec 1, 2019

@lexifdev
parse로 변경했습니다~

Staging automation moved this from Review in progress to Review approved Dec 2, 2019
@cmygray cmygray merged commit 33adc9d into master Dec 2, 2019
Staging automation moved this from Review approved to Done Dec 2, 2019
@cmygray
Copy link
Collaborator Author

cmygray commented Dec 2, 2019

제가 했습니다 (_ _)

@cmygray cmygray deleted the feat/list-accidents branch December 2, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fleta Fleta Fleta left review comments

@lexifdev lexifdev lexifdev approved these changes

@constmoon constmoon constmoon approved these changes

Assignees

@cmygray cmygray

Labels
None yet
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cmygray @lexifdev @Fleta @constmoon