This repository has been archived by the owner on Oct 30, 2021. It is now read-only.
Update error.php #25
Open
Update error.php #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes start at line 154. This gets the main menu displaying correctly but does not fix two other things: sticky footer (I don't know why the CSS is not applied) loading of a module within another module. (Tried loadmodule and loadposition to no avail; perhaps because I am using a custom html module for the footer ... the module class is not picked up either.) As well, I have not figured out how to make the button work for displaying the menu in tablet view. You can see my custom application here: http://silverplains.ca/floa.html
| <div class="navbar navbar-inverse navbar-fixed-top"> | ||
| <div class="navbar-inner"> | ||
| <div class="container"> | ||
| <a class="brand" href="<?php echo $this->baseurl; ?>"><?php echo htmlspecialchars($app->getCfg('sitename')) ?></a> |
There was a problem hiding this comment.
Wouldn't we also want the hamburger icon (https://github.com/construct-framework/bootstruct/blob/develop/index.php#L64-68) before here as well?
|
Definitely! I just couldn't figure out how to make it work. On my site, when I included it, it displayed in the middle of the navigation band, over top of everything else, instead of off to the right (as in the rest of the site). Plus nothing happened when I clicked on it. So, I included a link to the site map in the text, instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes start at line 154.
This gets the main menu displaying correctly but does not fix two other things:
sticky footer (I don't know why the CSS is not applied)
loading of a module within another module. (Tried loadmodule and loadposition to no avail; perhaps because I am using a custom html module for the footer ... the module class is not picked up either.)
As well, I have not figured out how to make the button work for displaying the menu in tablet view.
You can see my custom application here: http://silverplains.ca/floa.html