Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _emitfulltype to Optional and _emitprimitivetype to Peek #1029

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add _emitfulltype to Optional and _emitprimitivetype to Peek #1029

wants to merge 3 commits into from

Commits on Apr 24, 2023

  1. Add emitfulltype to Optional 

    I'm in the process of exporting Structs to Kaitai schemas, and the `Optional` field is something I use very often. 

I figure that since `Optional` is typically parsed only when data is available, then using `not _.io.eof` could be used to achieve similar functionality. Or is there something else I'm missing here?
    @wbarnha
    wbarnha committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    eadc665 View commit details
    Browse the repository at this point in the history

  2. add parenthesis to not() in order to properly generate python file

    @wbarnha
    wbarnha committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    0333a91 View commit details
    Browse the repository at this point in the history

  3. Add _emitprimitivetype to Peek

    @wbarnha
    wbarnha committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    5140f76 View commit details
    Browse the repository at this point in the history