Skip to content

Commit

Permalink
Merge pull request #2967 from consul/backport-1609-fix_skip_flaky_specs
Browse files Browse the repository at this point in the history
Fix flaky spec: Admin feature flags Enable a disabled feature
  • Loading branch information
javierm committed Oct 11, 2018
2 parents 8386972 + 5ae7a55 commit 5f83118
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions spec/shared/features/nested_imageable.rb
Expand Up @@ -175,15 +175,14 @@
end

scenario "Should show successful notice when resource filled correctly without any nested images", :js do
login_as user
visit send(path, arguments)

send(fill_resource_method_name) if fill_resource_method_name
click_on submit_button

if has_many_images
skip "no need to test, there are no attributes for the parent resource"
else
login_as user
visit send(path, arguments)

send(fill_resource_method_name) if fill_resource_method_name
click_on submit_button
expect(page).to have_content imageable_success_notice
end
end
Expand Down

0 comments on commit 5f83118

Please sign in to comment.