Skip to content

Commit

Permalink
Remove duplicated keys
Browse files Browse the repository at this point in the history
In the images.yml file we have a duplicate key with the same translation,
so we can remove it.

In the admin.yml file we have a duplicate key with different translation.

This translation is only used in 2 places in the application:
- In the administration table for collaborative legislation proposal index.
- In the <% provide :title do %> of the same page.

In this case I have no preference which one to keep.

So if I have to decide, although it is true that now is being applied the second
translation (Title), I think it makes more sense to use the first (Proposals).

In the admin table it makes sense to use either "Title" or "Proposals", but in
the page title it seems to make more sense to use "Proposals" instead of "Title".
  • Loading branch information
taitus committed Feb 21, 2023
1 parent 2dc10f4 commit c127228
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion config/locales/en/admin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,6 @@ en:
title: Proposals
back: Back
id: Id
title: Title
supports: Total supports
form:
custom_categories: Categories
Expand Down
1 change: 0 additions & 1 deletion config/locales/en/images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ en:
delete_button: Remove image
note: "You can upload one image of following content types: %{accepted_content_types}, up to %{max_file_size} MB."
add_new_image: Add image
title_placeholder: Add a descriptive title for the image
actions:
destroy:
notice: Image was deleted successfully.
Expand Down

0 comments on commit c127228

Please sign in to comment.