Make confirm alerts show the triggering action #4543
Conversation
rhian-cs
force-pushed
the
4015-detail-confirmation-alerts
branch
from
23f3d79
to
c4d0485
Compare
|
Hi, @rhian-cs 😄. Thank you so much for this pull request, and sorry for the late reply! 🙏. As part of a list of accessibility improvements regarding the links and buttons in the admin section, we implemented the detailed confirmation dialog in the admin section so it includes the name of the thing it acts on. The general message format is: Would it be possible to rebase this pull request against the latest master branch and update it so it uses that format in the public sections? If you can, great! 🎉. If you can't, it's OK; we understand we've kept you waiting for a review far too long. Thanks! |
|
Hello @javierm! I'll take another look, this PR was pretty big too. I hope it doesn't take too long since this branch is pretty outdated as well. We could perhaps try to redo it or split it into smaller PRs, WDYT? |
|
@rhian-cs Thanks! 😄 One pull request is OK, if that's fine with you. Regarding whether it's better to redo it or not, whatever suits you better works for us 😉. |
|
(I clicked on "close with comment" instead of "comment" by accident; please ignore that 😌) |
rhian-cs
force-pushed
the
4015-detail-confirmation-alerts
branch
4 times, most recently
from
ebf038f
to
e229347
Compare
|
Hello @javierm! I've rebased the branch and fixed the failing specs. I also ran all the specs locally. Could you take a look at this and let the CI run the tests? |
|
Hi, @rhian-cs 😄. This is great, thanks! We'll have a look at this pull request before the end of the year 👍. Oh, and thank you so much for taking the time to update the tests 😉. |
javierm
changed the title
javierm
force-pushed
the
4015-detail-confirmation-alerts
branch
2 times, most recently
from
8e33745
to
609e58c
Compare
References
Resolves #4015
Objectives
When the user clicks on certain buttons in the app, a confirmation alert is shown. However, this alert only asks the user "Are you sure?", but that doesn't give much information about what he should be sure of.
In this PR, I made the confirmation alerts show the triggering action, with the format:
Are you sure? %{action}For instance, if the user clicks on a 'Hide author' button, the alert now displays 'Hide author: Are you sure?'.
System specs were also updated to check if the confirmation alerts actually showed the triggering action.
Visual Changes
For example, in a page that has comments:
I didn't include a mobile screenshot because the dev tools still show the alerts as if it was in a computer, but since this is the standard alert, not much has changed.
Notes
Since this PR is already pretty big, I plan to open another one (if/after this one is merged) to update the other locales too.