Verify poll ballots #2858
Merged
Verify poll ballots #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
backport_1545-budget_poll_ballot
branch
from
b31533c
to
985b9ad
Compare
houndci-bot
reviewed
Nov 13, 2018
javierm
force-pushed
the
backport_1545-budget_poll_ballot
branch
3 times, most recently
from
cbe16cb
to
412e765
Compare
javierm
force-pushed
the
backport_1545-budget_poll_ballot
branch
from
412e765
to
d573581
Compare
houndci-bot
reviewed
Apr 10, 2019
| expect(poll_ballot.add_investment(investment.id)).to be(true) | ||
|
|
||
| other_heading = create(:budget_heading, group: group, price: 10000000) | ||
| other_investment = create(:budget_investment, :selected, price: 1000000, heading: other_heading) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [104/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
| poll_ballot.verify | ||
|
|
||
| expect(poll_ballot.ballot.lines.count).to eq(3) | ||
| expect(poll_ballot.ballot.lines.pluck(:investment_id).sort).to eq([investment.id, investment2.id, investment3.id].sort) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [125/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
| investment3 = create(:budget_investment, :selected, price: 2000000, heading: heading) | ||
| investment4 = create(:budget_investment, :selected, price: 2000000, heading: heading) | ||
|
|
||
| poll_ballot.update(data: [investment.id, investment2.id, investment3.id, investment4.id].join(",")) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
| let(:investment){ create(:budget_investment, :selected, price: 5000000, heading: heading) } | ||
| let(:poll) { create(:poll, budget: budget) } | ||
| let(:poll_ballot_sheet) { create(:poll_ballot_sheet, poll: poll) } | ||
| let(:poll_ballot) { create(:poll_ballot, ballot_sheet: poll_ballot_sheet, external_id: 1, data: investment.id) } |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [114/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
javierm
force-pushed
the
backport_1545-budget_poll_ballot
branch
from
d573581
to
ea8477c
Compare
javierm
force-pushed
the
backport_1545-budget_poll_ballot
branch
from
ea8477c
to
ea8ef72
Compare
javierm
force-pushed
the
backport_1545-budget_poll_ballot
branch
from
ea8ef72
to
aeb8410
Compare
voodoorai2000
approved these changes
Apr 11, 2019
This was referenced Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Verify
poll ballotsand create the correspondingbudget ballot linesNotes
The parts related to
city_heading, which are specific to Madrid, have not been backported.