Fix Rubocop warnings for Admin controllers #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
鉂わ笍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Visual Changes
Notes
Using
ci skipon commit message to avoid unnecessary Travis build (this PR does not affect at all existing functionality)Rubocop warnings for
SpendingProposalsweren't fixed since said functionality will be deprecated in upcoming CONSUL releasesSince there are so many Rubocop warnings, it's better to submit small PRs focusing on one module at a time so it's easier to review and to avoid possible conflicts 鈥擨'll be doing so in upcoming weeks but I encourage everybody to submit their own patches as well 馃