[Backport] Replace `.all.each` with `.find_each` to reduce memory usage #2887

aitbw · 2018-09-10T20:17:44Z

References

Related PR: Replace .all.each with .find_each to reduce memory usage AyuntamientoMadrid/consul#1566

As per this section in the Ruby on Rails documentation, the usage of .all.each over an ActiveRecord model might exceed the amount of memory available if said model is associated with a table with a considerable amount of records. Thus, it has been replaced where possible with .find_each, which has considerable performance gains

voodoorai2000 · 2018-09-17T17:06:41Z

Yes, great! 👌

aitbw added 4 commits September 10, 2018 11:38

Improve Rake tasks performance replacing .all.each with .find_each

24adf4b

Replace .all.each with .find_each when rendering cards

303b965

Replace .all.each with .find_each when seeding the DB

b6fe7ca

Replace .all.each with .find_each on admin specs

ffe421a

voodoorai2000 merged commit cae210c into consuldemocracy:master Sep 17, 2018

aitbw deleted the backport/db_queries branch September 17, 2018 17:10

voodoorai2000 assigned aitbw Sep 17, 2018

voodoorai2000 added this to Release 0.17 in Roadmap Sep 17, 2018