Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Test suite maintenance #2888

Merged
merged 9 commits into from
Sep 17, 2018
Merged

[Backport] Test suite maintenance #2888

merged 9 commits into from
Sep 17, 2018

Conversation

aitbw
Copy link
Collaborator

@aitbw aitbw commented Sep 10, 2018

References

Related links:

Objectives

  • Fixed example to properly test emails are being sent based on current user's locale (backported spec helper method from Madrid for this spec @ commit 1e1cb66)
  • Fixed RSpec's deprecation warnings for old stub syntax usage
  • DRY several features/emails examples
  • Refactored some tests to use the .check & .uncheck API to interact directly with the UI rather than with the DOM
  • Fixed some rubocop warnings
  • Disabled JS driver usage on some scenarios as they work without it
  • Fixed typos

Visual Changes (if any)

  • None

Notes

  • None

@voodoorai2000
Copy link
Member

Awesome @aitbw 🎉

@voodoorai2000 voodoorai2000 merged commit eb43593 into consuldemocracy:master Sep 17, 2018
@aitbw aitbw deleted the backport/test-suite-maintenance branch September 17, 2018 17:10
@voodoorai2000 voodoorai2000 added this to Release 0.17 in Roadmap Sep 17, 2018
@decabeza decabeza mentioned this pull request Mar 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aitbw aitbw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aitbw @voodoorai2000