Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make polls translatable #2914

Merged
merged 11 commits into from
Sep 26, 2018
Merged

Make polls translatable #2914

merged 11 commits into from
Sep 26, 2018

Conversation

microweb10
Copy link
Member

References

Issue #2735

Visual Changes

captura de pantalla 2018-08-04 a las 12 56 25
captura de pantalla 2018-08-04 a las 12 56 51
captura de pantalla 2018-08-04 a las 12 58 09
captura de pantalla 2018-08-04 a las 12 58 41
captura de pantalla 2018-08-04 a las 12 59 09
captura de pantalla 2018-08-04 a las 13 00 37

Notes

closes #2735

@microweb10 microweb10 mentioned this pull request Sep 20, 2018
Closed
mlovic
mlovic suggested changes Sep 20, 2018
View reviewed changes
Copy link
Collaborator

@mlovic mlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments involving some of the new changes in master. Everything else looks good to me!

app/views/admin/poll/questions/answers/_form.html.erb Outdated Show resolved Hide resolved
db/dev_seeds/polls.rb Outdated Show resolved Hide resolved
spec/helpers/ckeditor_spec.rb Outdated Show resolved Hide resolved
spec/features/translations/poll_question_answers_spec.rb Show resolved Hide resolved
app/models/poll/question/answer.rb Outdated Show resolved Hide resolved
javierm
javierm reviewed Sep 24, 2018
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! Thanks! I've only left a couple of comments about minor things.

app/controllers/admin/poll/questions/answers_controller.rb Show resolved Hide resolved
app/helpers/translatable_form_helper.rb Outdated Show resolved Hide resolved
spec/support/common_actions/ckeditor.rb Outdated Show resolved Hide resolved
javierm
javierm approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you soooooo much! 🎉. And thank you for your patience!

@voodoorai2000
Copy link
Member

Wow, this is beautiful!
Thank you so much @microweb10 for this implementation! 👌
And @mlovic for the altruistic reviews 🙌

@voodoorai2000 voodoorai2000 merged commit 4086220 into consuldemocracy:master Sep 26, 2018
@javierm javierm mentioned this pull request Sep 26, 2018
Merged
@microweb10 microweb10 deleted the make_polls_translatable branch September 26, 2018 14:02
@javierm javierm mentioned this pull request Sep 26, 2018
Merged
@mlovic mlovic mentioned this pull request Oct 19, 2018
Merged
@decabeza decabeza added this to Release 0.17 in Roadmap Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlovic mlovic mlovic requested changes

@javierm javierm javierm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make polls translatable
4 participants
@microweb10 @voodoorai2000 @javierm @mlovic