Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Random legislation proposal's order & pagination #2942

Merged
merged 10 commits into from
Oct 3, 2018
Merged

[Backport] Random legislation proposal's order & pagination #2942

merged 10 commits into from
Oct 3, 2018

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 1, 2018 •
edited

References

Objectives

Notes

  • ⚠️ Both tests added here are flaky tests, since they depend on two random numbers being different. However, sometimes the random numbers are the same.

@javierm javierm changed the title [WIP] [Backport] Random Legislation Process proposal's order & pagination [Backport] Random legislation proposal's order & pagination Oct 1, 2018
@javierm javierm mentioned this pull request Oct 2, 2018
Merged
@bertocq @javierm
Add random seed on Legislation Proposal controller for index
0cabede
@bertocq @javierm
Move onto proposals method the random seed call
4ab9b8b
@bertocq @javierm
Create @proposal variable con process controller for proposals list t…
599ddf8 
…hat use random seed
@bertocq @javierm
Add random order based on seed to legislation process proposals list
349abff
@bertocq @javierm
Add proposal phase values to legislation process factory
845f009
@bertocq @javierm
Add legislation proposal spec, with random list order scenario
d36e47c
@bertocq @javierm
Add helper function to get legislation proposals list order on featur…
89b8e51 
…e spec
@bertocq @javierm
Add legislation proposal feature scenario to check random order is co…
52df63c 
…nsistent with pagination
@bertocq @javierm
Add pagination to legislation process proposals list
c04b0ce
@bertocq @javierm
Force postgresql setseed value in correct range
df3df71 
This commit partially backports commit AyuntamientoMadrid/consul@f038399 by
taking only the parts affecting code already in CONSUL's main
repository.
@javierm javierm force-pushed the backport-feature/random_legislation_proposal branch from 8be5026 to df3df71 Compare October 3, 2018 11:46
@javierm
Copy link
Member Author

javierm commented Oct 3, 2018

The Travis build failure is actually caused by this pull request. Work on fixing it has started at AyuntamientoMadrid#1660.

@javierm javierm merged commit 127eef3 into master Oct 3, 2018
@javierm javierm deleted the backport-feature/random_legislation_proposal branch October 3, 2018 13:59
@javierm javierm self-assigned this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

Assignees

@javierm javierm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javierm @voodoorai2000 @bertocq