Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading title on account creation confirmation page (en, fr) #2944

Conversation

PierreMesure
Copy link
Collaborator

References

Fixes #2943

Objectives

See issue

Visual Changes

Before:
capture d ecran 2018-10-03 a 09 24 50

After:
capture d ecran 2018-10-03 a 09 58 47

Notes

I also corrected the French version.

@voodoorai2000 voodoorai2000 added this to Review in Roadmap Oct 17, 2018
@decabeza decabeza merged commit 33cc15c into consuldemocracy:master Nov 7, 2018
@decabeza
Copy link
Collaborator

decabeza commented Nov 7, 2018

Hi @PierreMesure,

I merged this one but also update the fr translation in Crowdin (to avoid future conflicts) 😌

For the future, for non en languages is better change keys only on Crowdin and not in the code. We have a ConsulBot who makes automatic PRs with new translations changes (like #3019) 😉

@decabeza decabeza moved this from Review to Release 0.18 in Roadmap Nov 14, 2018
@PierreMesure PierreMesure deleted the Misleading-title-on-account-creation-confirmation-page branch June 14, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants