Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations from Crowdin #2961

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Update translations from Crowdin #2961

merged 2 commits into from
Oct 10, 2018

Conversation

voodoorai2000
Copy link
Member

References

#2671

Objectives

  • Update translations from Crowdin
  • Fix problematic date translations

Visual Changes

None yet, but in the next PR we'll add all these languages to the language selector 馃帀

These translation keys are used to set the order in which a date object will be displayed[1]

They should not be translated, just reordered if it makes more sense of a given language

If the expected values are not found an exception is raised: ".date.order only accepts :year, :month and :day"

They should probably be somewhere else so that Crowdin translators don't feel the need to translate it. But that is a battle for another day 馃槍 for now simply fixing them

[1] https://guides.rubyonrails.org/i18n.html#action-view-helper-methods
@PierreMesure
Copy link
Collaborator

@voodoorai2000 Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants