Fix locale folder names #2963
Merged
Fix locale folder names #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoorai2000
force-pushed
the
locale_names
branch
from
15257f0
to
7541991
Compare
voodoorai2000
force-pushed
the
locale_names
branch
from
7541991
to
323f0fa
Compare
There seems to be some differences between the folder name and the locale name used in the files themselves. For example: the folder might have been called "de-DE", for German, but the files use one "de" And thus translations where not being displayed Using the locale key in the files and modifying the folder name if neccesary, let's see what happens in the next Crowdin pull, might need to review more thoroughly why this is happening (maybe due to custom settings in Crowdin)
voodoorai2000
force-pushed
the
locale_names
branch
from
323f0fa
to
cd22c44
Compare
javierm
approved these changes
Oct 17, 2018
voodoorai2000
added a commit
that referenced
this pull request
Nov 6, 2018
Crowind in sending folders named `de-DE` eventhough the locale in those files is just `de` We did a previous PR[1] trying to make this consistent But Crowdin keeps sending[2] this inconsistent locale folder and locale codes. So removing the duplicate folders named `de`. The locale is still being properly displayed as we are using the code `de` as the locale in application.rb [1] #2963 [2] #3005
decabeza
pushed a commit
that referenced
this pull request
Jan 21, 2019
Crowind in sending folders named `de-DE` eventhough the locale in those files is just `de` We did a previous PR[1] trying to make this consistent But Crowdin keeps sending[2] this inconsistent locale folder and locale codes. So removing the duplicate folders named `de`. The locale is still being properly displayed as we are using the code `de` as the locale in application.rb [1] #2963 [2] #3005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
PR: #2961
Objectives
Make translations findable by rails
What
Remove locale extended names from conflicting locales:
"de-DE" -> "de" https://crowdin.com/project/consul/de
"fa-IR" -> "fa" https://crowdin.com/project/consul/fa
"pl-PL" -> "pl" https://crowdin.com/project/consul/pl
"sq-AL" -> "sq" https://crowdin.com/project/consul/sq
"sv-SE" -> "sv" https://crowdin.com/project/consul/sv
Why
There seems to be some differences between the folder name and the locale name used in the files themselves.
For example: the folder was called "de-DE", for German, but the files used only the "de" key.
And thus translations where not being displayed.
Notes
Keep this PR in mind for the next Crowdin pull, let's hope folder and file locales are equal.
There are a couple of changes in this PR regarding language names, from an upcoming PR. No biggie 馃槍