Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix flaky spec: Admin legislation questions Update Valid legislation question #2976

Merged
merged 1 commit into from
Oct 17, 2018
Merged

[Backport] Fix flaky spec: Admin legislation questions Update Valid legislation question #2976

merged 1 commit into from
Oct 17, 2018

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 17, 2018

@javierm
Fix flaky legislation question spec
893f29a 
The test was failing sometimes because of the sequence:

within('#side_menu') do
  click_link "Collaborative Legislation"
end

click_link "All"
expect(page).to have_content 'An example legislation process'
click_link 'An example legislation process'

Right after clicking the "Collaborative Legislation" link, the link 'An
example legislation process' is already available. So sometimes Capybara
might click the links "All" and 'An example legislation process' at more
or less the same time, causing the second link not to be correctly
clicked.

Making sure the "All" link doesn't exist anymore we guarantee Capybara
will wait for the previous AJAX request to finish before clicking the
next link.

Note the test to "Create Valid legislation question" is almost identical
but it doesn't fail because it doesn't use Capybara's JavaScript driver.
@javierm javierm merged commit 4f831b9 into master Oct 17, 2018
@javierm javierm deleted the backport-1603-fix_flaky_legislation_questions_spec branch October 17, 2018 17:18
@javierm javierm self-assigned this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

Assignees

@javierm javierm

Labels
Flaky spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky spec: Admin legislation questions Update Valid legislation question
2 participants
@javierm @voodoorai2000