Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI design #2983

Merged
merged 6 commits into from
Oct 19, 2018
Merged

UI design #2983

merged 6 commits into from
Oct 19, 2018

Conversation

decabeza
Copy link
Collaborator

Objectives

This PR fix some UI details:

  • Updates active to is-active class for view mode.

  • Fixes color of datepicker calendar.

  • Removes unnecessary styles for admin budgets groups.

  • Removes styles to fix logo size on devise views.

  • Removes condition to allow images and data equalizer on proposals (the proposal image only can be present if feature :allow_images is enabled, so there is no need to include both conditions. The data-equalizer also is unnecessary because the :thumb image already has an fix height).

  • Removes unnecessary style to orbit slide.

Visual Changes

Fixes color of datepicker calendar

4 before

4 after

Removes unnecessary styles for admin budgets groups
3 before
3 after

Removes styles to fix logo size on devise views
2 before
2 after

The proposal image only can be present if feature :allow_images is enabled, so there is no need to include both conditions. The data-equalizer also is unnecessary because the :thumb image already has an fix height.
@decabeza decabeza merged commit 7009a21 into master Oct 19, 2018
@decabeza decabeza deleted the ui-design branch October 19, 2018 11:01
@decabeza decabeza moved this from Review to Release 0.17 in Roadmap Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants