Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hound basic configuration #2987

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Add Hound basic configuration #2987

merged 3 commits into from
Oct 29, 2018

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 26, 2018

Objectives

  • Add a Hound configuration file so Hound uses some basic rubocop rules
  • Help us follow our own coding standards by automatically catching things we might forget like indentation issues

Notes

  • We need to activate Hound so it will automatically scan pull requests in this repository.
  • We're only adding a few basic rules so contributors aren't overwhelmed by comments regarding all our code conventions.

@javierm
Remove rubocop_todo file
48140f7 
No developers are maintaining it anymore.
@javierm
Add basic rubocop configuraton for Hound
4048d17 
This way we can ask contributors to follow some basic guidelines like
removing trailing whitespaces while not overwhelming them with all our
rules.
voodoorai2000
voodoorai2000 approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@voodoorai2000 voodoorai2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@javierm javierm merged commit c0b8bd9 into master Oct 29, 2018
@javierm javierm mentioned this pull request Oct 29, 2018
Merged
@javierm javierm deleted the houndci_basic branch October 29, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

@decabeza decabeza decabeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javierm @voodoorai2000 @decabeza