[Backport] Social meta tags #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decabeza
force-pushed
the
social-meta-tags
branch
from
9e7cf1c
to
c2121de
Compare
decabeza
force-pushed
the
social-meta-tags
branch
from
c2121de
to
cd7bff0
Compare
voodoorai2000
approved these changes
Oct 31, 2018
javierm
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a backport of AyuntamientoMadrid#1681
Objectives
This PR removes custom content on proposal votes view and improves social share messages for proposals creating a new
proposals/_social_share.html.erbpartial.Before the share messages was:
{proposal_summary}{proposal_title} #twitter_hashtagNo message only proposal's urlThe new messages are:
Facebook:
I supported the proposal %{summary} in %{org}. If you're interested, support it too!Twitter, Telegram and WhatsApp:
I supported the proposal %{summary} in %{mobile}. If you're interested, support it too!This PR also refactors the social meta tags spec.
Visual changes
Before
After
