Update i18n from Crowdin #2998
Merged
Update i18n from Crowdin #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 26, 2018 10:51
We forgot to do it when we created the translation tables, and so now we need to make sure we don't overwrite existing translations.
This way the task to migrate the data doesn't have to be run manually if these migrations weren't already executed.
In theory, it should never happen, but that's why exceptions exist.
This way we can check everything is OK before actually migrating the data to the translations tables.
We think aborting the migration will generate more headaches to system administrators, who will have to manually check and fix every invalid record before anything can be migrated.
Ruby can't have hyphens in method names, so sending something like `record.title_pt-BR` would raise an exception. Using globalize's `localized_attr_name_for` method fixes the bug. Thanks Marko for the tip.
No developers are maintaining it anymore.
This way we can ask contributors to follow some basic guidelines like removing trailing whitespaces while not overwhelming them with all our rules.
As pointed out in PR consul#2734: "After clicking the first link, there's an AJAX request which replaces the existing `.in-favor a` and `.against a` links with new elements. So if Capybara tries to click the existing `.against a` link at the same moment it's being replaced, clicking the link won't generate a new request". Making Capybara check the page for new content before clicking the second link solves the problem. This commit solves issues afecting both Madrid's fork and the original CONSUL repo.
We've agreed `User.new` is easier to read than `described_class.new` and since we are ignoring Hound's comments regarding this topic, we might as well remove it.
The content 'An example legislation process' is already present before we click the "All" link. Not checking the page content properly sometimes resulted in the second click being executed before the first request had been completed, making the spec fail. By checking the "All" link isn't present anymore, we guarantee the request has been completed before trying to click the 'An example legislation process' link.
decabeza
force-pushed
the
i18n-uptade-crowdin
branch
from
7932912
to
2c51584
Compare
decabeza
force-pushed
the
i18n-uptade-crowdin
branch
from
2c51584
to
cb2b2ac
Compare
voodoorai2000
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR updates Crowdin changes with
masterbranch including the PR from Crowdin bot: #2965 and changes made on #2974Objectives
masterbranch to resolve conflicts on .yml files