i18n remove date.order key #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are having some trouble where people are translating the `date.order` key. These keys are supposed to have the symbols :year, :month, :day and not be translated to for exampe :año, :mes, :día Really these keys are not needed in the translation file as rails is picking up `date.format`[1] key instead of `date.order` So we can safely remove this problematic key [1] https://github.com/consul/consul/blob/master/config/locales/en/rails.yml#L54
javierm
approved these changes
Nov 6, 2018
This was referenced Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
PR Crowdin bot: #3005
Objectives
Remove problematic key
date.order.People are translating the
date.orderkey, however, this key is supposed to have the symbols:year, :month, :dayand not be translated to for example:año, :mes, :díaas that raises an exception.These keys are only used for defining the order of date selects which are not currently in use in CONSUL, so we can safely remove them for now.