[Backport] Fix flaky spec: Admin budget investment mark/unmark visible to valuators #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since one of them was slightly different, I've kept the most recent one.
As mentioned in the comments in PR #1256: "These failures take place because the checkbox is already present before clicking in 'under valuation', and so Capybara doesn't have to wait for the 'under valuation' request to finish before clicking the checkbox." So sometimes Capybara tries to check/uncheck the checkbox at the same time that checkbox is being replaced by the new content, resulting in no request being sent to the server. Making Capybara check the page to ensure the new content is already loaded before checking/unchecking the checkbox solves the problem.
javierm
force-pushed
the
backport-1194-fix_flaky_valuators_specs
branch
from
1c9dcf0
to
579ea8a
Compare
voodoorai2000
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References