Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add map to sidebar on Heading's page #3038

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Add map to sidebar on Heading's page #3038

merged 2 commits into from
Dec 11, 2018

Conversation

MatheusMiranda
Copy link
Collaborator

Signed-off-by: Matheus Miranda matheusmirandalacerda@gmail.com

References

Related to issue: #2430

Objectives

Add a map at the sidebar, on Heading's page. In order to visualize the investiments related to a heading.

heading_investments_page

Visual Changes

On administration section, when editing a heading, now there are two fields related to the coordinates of the heading. Coordinates indicating where the map will be centered on..

heading_edit_page

@MatheusMiranda MatheusMiranda mentioned this pull request Nov 14, 2018
Closed
@decabeza
Copy link
Collaborator

Hi @MatheusMiranda! Thanks for the PR! 🙏 😌

I leave you some comments 😉

voodoorai2000
voodoorai2000 reviewed Nov 15, 2018
View reviewed changes
Copy link
Member

@voodoorai2000 voodoorai2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic @MatheusMiranda 👏🎉

A couple of comments regarding specs:

spec/features/budgets/investments_spec.rb Outdated Show resolved Hide resolved
@MatheusMiranda
Copy link
Collaborator Author

@decabeza, @voodoorai2000 and @javierm thanks for the revision. I'm gonna apply the feedbacks 👌

@MatheusMiranda
Add map to sidebar on Heading's page
06f07b1 
Signed-off-by: Matheus Miranda <matheusmirandalacerda@gmail.com>
@voodoorai2000 voodoorai2000 added this to Review in Roadmap Nov 19, 2018
@microweb10 microweb10 merged commit 9aab3dd into consuldemocracy:master Dec 11, 2018
@microweb10
Copy link
Member

@MatheusMiranda thank you for this PR! 😃 🎉

@decabeza decabeza moved this from Review to Release 0.18 in Roadmap Dec 13, 2018
This was referenced Dec 18, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierm javierm javierm left review comments

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

@decabeza decabeza decabeza approved these changes

Assignees

@MatheusMiranda MatheusMiranda

Labels
Budgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MatheusMiranda @decabeza @microweb10 @voodoorai2000 @javierm