Added feature to add content block to headings in sidebar #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 15, 2018
app/controllers/admin/site_customization/content_blocks_controller.rb
Outdated
Show resolved
Hide resolved
milber
force-pushed
the
content_blocks_for_headings
branch
2 times, most recently
from
d4025b9
to
7e3c584
Compare
decabeza
reviewed
Nov 19, 2018
decabeza
reviewed
Nov 19, 2018
decabeza
reviewed
Nov 19, 2018
decabeza
reviewed
Nov 19, 2018
decabeza
reviewed
Nov 19, 2018
decabeza
reviewed
Nov 19, 2018
decabeza
reviewed
Nov 19, 2018
|
Hi @milber, Thanks for the PR! 🙏 😌 I leave you some comments on the code 😉 |
milber
force-pushed
the
content_blocks_for_headings
branch
from
7e3c584
to
9f455b9
Compare
|
Hi @milber |
microweb10
approved these changes
Dec 11, 2018
microweb10
added a commit
that referenced
this pull request
Dec 12, 2018
In this PR #3043 there were some change requests. In order to keep moving we decided to merge the PR and do the changes ourselves.
microweb10
added a commit
to AyuntamientoMadrid/consul
that referenced
this pull request
Dec 28, 2018
In this PR consuldemocracy#3043 there were some change requests. In order to keep moving we decided to merge the PR and do the changes ourselves.
decabeza
pushed a commit
that referenced
this pull request
Jan 21, 2019
In this PR #3043 there were some change requests. In order to keep moving we decided to merge the PR and do the changes ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Why is this Needed?
People are often asking for more information about a heading. Headings are often "districts" so they want to know things like:
Who is leading the district?
What projects have been voted on in the past?
What are the characteristics of this district?
By providing a flexible content box in the heading area, administrators can provide their users with whatever types of information and links that are requested by the community.
Description
We make it possible for the admin to activate the content block on a heading by clicking a checkbox under the heading.
Visual Changes
Notes