Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Administrator ID #3056

Merged
merged 2 commits into from
Nov 26, 2018
Merged

[Backport] Administrator ID #3056

merged 2 commits into from
Nov 26, 2018

Conversation

decabeza
Copy link
Collaborator

References

This is a backport of AyuntamientoMadrid#1719

Objectives

  • Adds Administrator ID on admin administrators index page.
  • Refactors admin administrators spec: this refactoring avoids "Use let instead of an instance variable" rubocop warning. 馃槍

Visual Changes

administrators_1

This is useful for example to identify an admin comment by their id:

administrators_2

This refactoring avoids "Use let instead of an instance variable" rubocop warning
@decabeza decabeza moved this from Review to Release 0.18 in Roadmap Nov 26, 2018
@decabeza decabeza merged commit 1bb50cb into master Nov 26, 2018
@decabeza decabeza deleted the administrator-id branch November 26, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants