Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for missing feature specs for Poll::Question::Answer #3063

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Check for missing feature specs for Poll::Question::Answer #3063

merged 3 commits into from
Feb 18, 2020

Conversation

microweb10
Copy link
Member

@microweb10 microweb10 commented Nov 25, 2018 •
edited

Objectives

Make sure all scenarios for Poll::Question::Answer and Poll::Answer were tested

@microweb10 microweb10 changed the title Add missing feature spec for Poll::Question::Answer (Update) [WIP] Add missing feature spec for Poll::Question::Answer (Update) Dec 5, 2018
@javierm javierm added the Specs label Oct 20, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Oct 20, 2019
@javierm javierm moved this from Reviewing to Doing in Roadmap Oct 20, 2019
javierm
javierm reviewed Oct 20, 2019
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this pull request WIP? I think you told me months ago, but I've forgotten 😅.

spec/features/polls/answers_spec.rb Outdated Show resolved Hide resolved
@microweb10
Copy link
Member Author

Why is this pull request WIP? I think you told me months ago, but I've forgotten 😅.

Since we have Poll::Answer and Poll::Question::Answer this PR was wrongly created. We have to check what tests do we currently have and which ones do we need to add in order to fully cover the 2 different kinds of answers.

It's been in WIP because I haven't had time to look at it since then 😅

@javierm javierm removed this from Doing in Roadmap Oct 23, 2019
@microweb10
Move Poll::Question::Answer images tests to the right place
cf1f688
@microweb10
Remove duplicated test
925964f 
This scenario was already tested in
spec/features/admin/poll/questions/answers/videos/videos_spec.rb
@microweb10
Remove duplicated tests
6d6f173 
These scenarios were already tested in
spec/features/admin/poll/questions/answers/answers_spec.rb
@microweb10
Copy link
Member Author

After reviewing this PR I have concluded in:

  • The test behave like nested imageable should be in the admin part (first commit)
  • The scenario about adding a video to an answer was already tested in the admin part (second commit)
  • The scenarios about listing and creating answers were already tested in the admin part (third commit)
  • No extra tests are needed since non-admin users cannot CRUD the answers, they can only vote and voting tests are already covered ☺️

So I have removed the WIP, edited the description of the PR and I think it can be merged

@microweb10 microweb10 changed the title [WIP] Add missing feature spec for Poll::Question::Answer (Update) Check for missing feature specs for Poll::Question::Answer Jan 19, 2020
@microweb10 microweb10 added this to Reviewing in Roadmap via automation Jan 19, 2020
javierm
javierm approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 😄

Roadmap automation moved this from Reviewing to Testing Feb 18, 2020
@microweb10 microweb10 merged commit 377c24f into consuldemocracy:master Feb 18, 2020
Roadmap automation moved this from Testing to Release 1.1.0 Feb 18, 2020
@microweb10 microweb10 deleted the poll_question_answer_update_spec branch February 18, 2020 12:38
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
@microweb10
Merge pull request consuldemocracy#3063 from microweb10/poll_question…
3c7a815 
…_answer_update_spec

Check for missing feature specs for Poll::Question::Answer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierm javierm javierm approved these changes

Assignees

@javierm javierm

@microweb10 microweb10

Labels
Specs
Projects
No open projects
Roadmap
  
Release 1.1.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@microweb10 @javierm