[Backport] Make milestones code reusable #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
backport-share_milestoneable_code
branch
from
f25d920
to
e26373f
Compare
|
Travis failure isn't related to the code in this pull request. |
voodoorai2000
approved these changes
Dec 11, 2018
So it isn't specific to budget investments anymore.
javierm
force-pushed
the
backport-share_milestoneable_code
branch
from
e26373f
to
df29b49
Compare
|
Travis failure isn't related to this code, although we had only seen it fail on the rails 5 branch until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Make all code related to milestones easy to reuse, so it can be implemented by proposals: