[Backport] Fix milestone validation #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same cases are tested in the previous `describe` block.
We had a validation rule for milestones which made sure either the status or the description was present. However, since the description is now translatable, the validation error wasn't being displayed in the admin form. Moving the validation rule to the translation object fixes the problem. However, the translation object needs to check an attribute in the milestone object in order to know whether the description is required or not. This is tricky because by default it loads the milestone object from the database, meaning it doesn't work with new records and it ignores params sent by the browser. The solution is to manually assign the globalized model before validating the object. It's a hack, but apparently Rails doesn't provide a better way to handle this case [1]. [1] rails/rails#32024
|
Travis failure isn't related to this code. |
voodoorai2000
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Make the admin form display a validation error when both description and status are blank.