Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Edit only existing languages in milestones summary #3103

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

javierm
Copy link
Member

@javierm javierm commented Dec 12, 2018

References

Objectives

Avoid validation errors when trying to add a new language for the milestones summary form. Languages should be added from the "infomation" form, and thie milestones summary form should be used to edit existing languages.

Visual Changes

Before

Options to add and remove languages

After

No options to add and remove languages

Adding languages using this form would result in validation errors since
there's no way to fill in the title for the new translation.
@javierm
Copy link
Member Author

javierm commented Dec 12, 2018

Travis failures aren't related to this pull request.

@javierm javierm merged commit e1620df into master Dec 13, 2018
@javierm javierm deleted the backport-update_legislation_milestone_form branch December 13, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants