Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Widgets dev seeds #3104

Merged
merged 1 commit into from
Dec 13, 2018
Merged

[Backport] Widgets dev seeds #3104

merged 1 commit into from
Dec 13, 2018

Conversation

decabeza
Copy link
Collaborator

References

This is a backport of AyuntamientoMadrid#1740

Objectives

Updates deprecated constants on dev_seed/widgets. This change avoid warning message when run rake db:dev_seed

Creating header and cards for the homepage
/app/db/dev_seeds/widgets.rb:25: warning: constant ::TRUE is deprecated
/app/db/dev_seeds/widgets.rb:43: warning: constant ::FALSE is deprecated
/app/db/dev_seeds/widgets.rb:61: warning: constant ::FALSE is deprecated
/app/db/dev_seeds/widgets.rb:79: warning: constant ::FALSE is deprecated

Notes

Ruby 2.4 has deprecated toplevel constants TRUE, FALSE and NIL

@decabeza decabeza self-assigned this Dec 12, 2018
@decabeza decabeza added this to Review in Roadmap Dec 12, 2018
@decabeza decabeza merged commit e7ab377 into master Dec 13, 2018
@decabeza decabeza deleted the seeds-widgets branch December 13, 2018 06:15
@decabeza decabeza moved this from Review to Release 0.18 in Roadmap Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierm javierm javierm approved these changes

Assignees

@decabeza decabeza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@decabeza @javierm