[Backport] Fix flaky spec checking price without currency symbol #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin/rspec --seed 53044
Failures:
1) Budget Investments Balloting Phase Confirm
Failure/Error: expect(page).not_to have_content "#{sp3.price}"
expected not to find text "100" in "Global Group - Global Heading You still have €999,989 to invest. Amount spent €11 Budget Investment 1006 title €10 Budget Investment 1005 title €1"
# ./spec/features/budgets/investments_spec.rb:1466:in `block (4 levels) in <top (required)>'
# ./spec/features/budgets/investments_spec.rb:1458:in `block (3 levels) in <top (required)>'
# -e:1:in `<main>'
Failed examples:
rspec ./spec/features/budgets/investments_spec.rb:1419 # Budget Investments Balloting Phase Confirm
javierm
approved these changes
Dec 18, 2018
voodoorai2000
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
PR AyuntamientoMadrid#1758
Error message
bin/rspec --seed 53044 Failures: 1) Budget Investments Balloting Phase Confirm Failure/Error: expect(page).not_to have_content "#{sp3.price}" expected not to find text "100" in "Global Group - Global Heading You still have €999,989 to invest. Amount spent €11 Budget Investment 1006 title €10 Budget Investment 1005 title €1" # ./spec/features/budgets/investments_spec.rb:1466:in `block (4 levels) in <top (required)>' # ./spec/features/budgets/investments_spec.rb:1458:in `block (3 levels) in <top (required)>' # -e:1:in `<main>' Failed examples: rspec ./spec/features/budgets/investments_spec.rb:1419 # Budget Investments Balloting Phase ConfirmExplain why the test is flaky
When we check the price not to appear we don't include the currency symbol, so if the number is anywhere else the test will fail.
Explain why your PR fixes it
We will check the number doesn't appear, but with the currency symbol.