Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Honeypot on users sign up form #3124

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Conversation

decabeza
Copy link
Collaborator

References

This is a backport of AyuntamientoMadrid#1772

Objectives

Changes honeypot :family_name to :address on users sign up form. This prevent a real user fill this honeypot hidden field when use "autofill" browser feature.

We use HTML <input> autocomplete = "off" in some fields in this form (honeypot included) but it seems new browsers are ignoring this value.

Visual Changes

The honeypot field is hidden but I change styles to show it and view the changes

BEFORE
before

AFTER
after

Notes

Some info about HTML autocomplete = "off":

HTML autocomplete Attribute
AutoComplete=Off” not working on Google Chrome Browser
Chrome ignores autocomplete=“off”

@decabeza decabeza added the Bug label Dec 21, 2018
@decabeza decabeza self-assigned this Dec 21, 2018
@decabeza decabeza added this to Review in Roadmap Dec 21, 2018
@decabeza decabeza merged commit c7cd6ca into master Dec 21, 2018
@decabeza decabeza deleted the honeypot-sign-up branch December 21, 2018 14:51
@decabeza decabeza moved this from Review to Release 0.18 in Roadmap Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants