Bring back date order translations #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
fix_date_order_translations
branch
2 times, most recently
from
c6f5422
to
6ef5b7c
Compare
decabeza
approved these changes
Dec 21, 2018
javierm
force-pushed
the
fix_date_order_translations
branch
from
6ef5b7c
to
774d8bb
Compare
Not doing so caused crashes on applications which don't fall back to English when a translation is missing. We're adding them in a separate file so we can exclude it from crowdin and so translators don't translate symbols as if they were words which need translation.
javierm
force-pushed
the
fix_date_order_translations
branch
from
774d8bb
to
e34a827
Compare
voodoorai2000
approved these changes
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
We removed the
date.ordertranslations because translators were ttranslating thedate.orderkeys, which are supposed to have the symbols:year,:month, and:dayand are not supposed to be translated to symbols like:año,:mesand:día.However, we need those keys to be defined so forks which don't fall back to English when translations aren't available can render the residence verification form without the application crashing
Objectives
date.orderkeys to a different file so it can be excluded from crowdin