Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image to legislation processes and banner colors #3152

Conversation

NahiaSolutions
Copy link
Contributor

Objectives

  • Add and image to legislative process and banner colors (both optional).

Visual Changes

  • Added option to attach an image to the process, and new form fields to add a background color and font color to the process's banner.

screenshot from 2019-01-02 10-55-48

  • The image is visible under the share options inside the process's banner.

screenshot from 2019-01-02 10-56-16

Notes

  • Migration is pending to add the background and font colors to the process in the data base.

app/assets/stylesheets/pages.scss Outdated Show resolved Hide resolved
app/assets/javascripts/legislation_admin.js.coffee Outdated Show resolved Hide resolved
app/assets/javascripts/legislation_admin.js.coffee Outdated Show resolved Hide resolved
app/assets/javascripts/legislation_admin.js.coffee Outdated Show resolved Hide resolved
app/assets/javascripts/legislation_admin.js.coffee Outdated Show resolved Hide resolved
app/assets/javascripts/legislation_admin.js.coffee Outdated Show resolved Hide resolved
app/assets/javascripts/legislation_admin.js.coffee Outdated Show resolved Hide resolved
app/assets/javascripts/legislation_admin.js.coffee Outdated Show resolved Hide resolved
app/assets/javascripts/legislation_admin.js.coffee Outdated Show resolved Hide resolved
app/assets/javascripts/legislation_admin.js.coffee Outdated Show resolved Hide resolved
@NahiaSolutions NahiaSolutions force-pushed the add_image_to_legislation_processes branch from 84cb730 to bf219a0 Compare January 21, 2019 17:09
click_link 'Click to visit'

expect(page).to have_content 'An example legislation process'
expect(page).not_to have_content 'Summary of the process'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants