[Backport] Add progress bars to milestones public view #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decabeza
force-pushed
the
milestones_public_progress_bar
branch
from
8d74c8c
to
8a6c618
Compare
Note we require extra <span> tags because the <progress> tag is an empty tag (like <img>), and so it can't have ::before or ::after pseudo-elements. There's a workaround for that, but currently it only works on Chrome. For some reason, the text seems to be slightly misaligned vertically in all implementations I've tried. So the `top: -0.1rem` rule is a hack to align it properly.
These progress bars don't have any translatable attributes.
We're going to introduce progress bars in the public view as well, and it's more consistent with "admin_milestoneable".
Before, this tab only was show if were some milestone
decabeza
force-pushed
the
milestones_public_progress_bar
branch
from
8a6c618
to
78d8e34
Compare
decabeza
force-pushed
the
milestones_public_progress_bar
branch
from
7fddb0c
to
d650b90
Compare
voodoorai2000
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a backport of AyuntamientoMadrid#1813
This close consul#3135
Objectives
Visual Changes