[Backport] Use find instead of find_by_id #3234

microweb10 · 2019-01-25T08:14:02Z

References

Objectives

Use correct param in controller
Remove unused before_action
Use find instead of find_by_id
Add method find_by_slug_or_id to Sluggable module

This method will raise an exception if resource is not found when trying to call score_action on nil. Prefer to raise a 404 HTML NotFound error instead.

Make it easier to find by slug or id for sluggable models. Will return nil if resource is not found.

microweb10 added 4 commits January 25, 2019 08:48

Use correct param in controller

0af5972

Remove unused before_action

23b6e38

Use find instead of find_by_id

9a23393

This method will raise an exception if resource is not found when trying to call score_action on nil. Prefer to raise a 404 HTML NotFound error instead.

Add method find_by_slug_or_id to Sluggable module

3bf2fa1

Make it easier to find by slug or id for sluggable models. Will return nil if resource is not found.

microweb10 force-pushed the use_find_instead_of_find_by_id branch from 1173e23 to 3bf2fa1 Compare January 29, 2019 16:34

voodoorai2000 approved these changes Jan 30, 2019

View reviewed changes

microweb10 self-assigned this Jan 30, 2019

microweb10 added this to Release 0.19 in Roadmap Jan 30, 2019

microweb10 merged commit 0e9fd64 into master Jan 30, 2019

microweb10 deleted the use_find_instead_of_find_by_id branch January 30, 2019 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport] Use find instead of find_by_id #3234

[Backport] Use find instead of find_by_id #3234

microweb10 commented Jan 25, 2019 •

edited

[Backport] Use find instead of find_by_id #3234

[Backport] Use find instead of find_by_id #3234

Conversation

microweb10 commented Jan 25, 2019 • edited

References

Objectives

microweb10 commented Jan 25, 2019 •

edited