[Backport] Return a String in I18n method 'pluralize' #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a translation was missing returning a Fixnum was raising an exception 'undefined method X for Fixnum'.
microweb10
changed the title
voodoorai2000
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a backport of the PR AyuntamientoMadrid#1864
Objectives
If a translation was missing returning a
Fixnumcould cause to raise an exception "undefined method X for Fixnum".For instance, we were getting the Exception "ActionView::Template::Error: undefined method 'pluralize' for 1:Fixnum" when calling
model_name.human(used by the gemkaminariin the helper methodpage_entries_info).