Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix accessibility and HTML warnings #3366

Merged
merged 8 commits into from
Mar 14, 2019
Merged

[Backport] Fix accessibility and HTML warnings #3366

merged 8 commits into from
Mar 14, 2019

Conversation

decabeza
Copy link
Collaborator

References

Backport of AyuntamientoMadrid#1907

We use Rocket Validator to check weekly HTML and A11y issues on code.

Objectives

  • Add missing <tr> tags on users views.
  • Show proposal question only if it is present: this prevent render an empty <h4> tag.
  • Change label for search text: label wraps input field to prevent error on missing label (hided by CSS).
  • Fix heading levels on custom welcome index.
  • Improve color contrast on leaflet map.
  • Remove unnecessary anchor link for finished budgets.
  • Replace summary to title on proposals social share message.
  • Replace spaces to %20 on WhatsApp share url: this avoid have an invalid href with spaces.
  • Add missing mobile social share message.
  • Remove unnecessary type on script tags.

Visual Changes

Share on WhatsApp work as expected
whatsapp

@decabeza decabeza merged commit f99a92a into master Mar 14, 2019
@decabeza decabeza deleted the a11y-fixes branch March 14, 2019 13:08
@decabeza decabeza added this to Release 0.20 in Roadmap Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants