Improve Admin settings section #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make easier to group settings by using prefixes - Add method to rename setting keys - Add method to remove setting keys
houndci-bot
reviewed
Mar 19, 2019
- Rename partial views for tabs. - Extract tables settings to reuse across the tabs.
- Rename map settings keys - Add fields for latitude, longitude and zoom - Add a callout message on how to enable map feature
microweb10
force-pushed
the
admin_settings_improvement
branch
from
054a47a
to
ee537f3
Compare
decabeza
approved these changes
Mar 19, 2019
- Rename setting keys - New tab por participation processes - Hide these settings from features tab
- Rename homepage widget settings keys
- Rename html settings keys - Show html settings next to content blocks page - Hide html settings from configuration tab
microweb10
force-pushed
the
admin_settings_improvement
branch
from
ee537f3
to
e04fd74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a backport of AyuntamientoMadrid#1918
closes #3333
Objectives
Visual Changes (defined in the issue)
[IMAGE_1]
[IMAGE_2]
[IMAGE_3]
[IMAGE_4]
Does this PR need a Backport to CONSUL?
Yes
Release notes⚠️
Please note that if you are upgrading from an older version you will need to have the correct settings keys, by running this command:
bin/rake settings:rename_setting_keys RAILS_ENV=production