Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legislation process feed order #3400

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Fix legislation process feed order #3400

merged 1 commit into from
Mar 22, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Mar 21, 2019

References

Objectives

Make the legislation process shown on a feed consistent.

Notes

As mentioned in the commit message, we need to add an ORDER BY clause; not doing so was causing different processes to show up sometimes. Quoting the PostgreSQL manual:

Because the order of the rows in the database table is unpredictable, when you use the LIMIT clause, you should always use the ORDER BY clause to control the order of rows. If you don’t do so, you will get an unpredictable result set.

We need to add an ORDER BY clause; not doing so was causing different
processes to show up sometimes. As mentioned in the PostgreSQL manual:

> Because the order of the rows in the database table is unpredictable,
> when you use the LIMIT clause, you should always use the ORDER BY
> clause to control the order of rows. If you don’t do so, you will get
> an unpredictable result set.
@javierm javierm merged commit 7d472b7 into master Mar 22, 2019
@javierm javierm deleted the fix_processes_order branch March 22, 2019 10:14
@voodoorai2000 voodoorai2000 added this to Release 1.0.0-beta in Roadmap Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky spec: Widget::Feed kinds #processes returns open and published processes
3 participants