Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete rake tasks #3401

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Conversation

javierm
Copy link
Member

@javierm javierm commented Mar 22, 2019

References

Objectives

  • Remove obsolete code
  • Remove useless tests which make Travis builds take longer

Notes

These tasks dealt with data migrations or stats generations which were done only once, so we don't need them anymore. New CONSUL installations don't need these tasks, and existing CONSUL installations will execute them when upgrading one release at a time.

These tasks dealt with data migrations or stats generations which were
done only once, so we don't need them anymore.

New CONSUL installations don't need these tasks, and existing CONSUL
installations will execute them when upgrading one release at a time.
@javierm javierm merged commit 6593bc0 into master Mar 22, 2019
@javierm javierm deleted the backport-remove_obsolete_rake_tasks branch March 22, 2019 13:08
@voodoorai2000 voodoorai2000 added this to Release 1.0.0-beta in Roadmap Apr 26, 2019
@PierreMesure
Copy link
Collaborator

Not super fun upgrading one version at a time 😬. I'm not sure how many will face this problem but it probably would have been better to leave these files for at least a few more updates.

@javierm
Copy link
Member Author

javierm commented May 7, 2019

Thank you for the feedback, Pierre 😄. For now we don't plan to support skipping versions when upgrading because the amount of obsolete code/data we'd need to maintain would be just too much. However, we know the upgrading process should be easier 😌. We've got some ideas to simplify the upgrade, like automatically adding new settings (javierm#6) and adding the consul:upgrade task (issue #2831).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants