Fix flaky spec: Ballots Groups Change my heading #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were sending a new request without checking the previous one had finished, and if it hadn't finished, the test failed. This test started to fail after upgrading to Rails 5, since we removed the change done in commit eda47ef which set `config.allow_concurrency` to `false` in the test environment. While we could re-introduce that configuration option, which might have side effects, an easier solution is to check an AJAX request has been completed before sending a new request depending on the previous one seems to be a more solid option. Note this test failed with two possible errors: "undefined method `heading' for nil:NilClass" and "stale element reference: element is not attached to the page document". This change fixes the second error; it might fix the first error as well, but since I couldn't reproduce it locally, we'll only be sure when this test stops failing in travis builds.
voodoorai2000
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Check page after an AJAX call so the test doesn't fail sometimes due to two requests being processed simultaneosly.
Notes
config.allow_concurrencytofalsein the test environment.