Always use map image from admin site customization images #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
microweb10
approved these changes
May 7, 2019
voodoorai2000
approved these changes
May 7, 2019
| @@ -2,5 +2,5 @@ | |||
| <h2 class="sidebar-title"><%= t("shared.tags_cloud.districts") %></h2> | |||
| <br> | |||
| <%= link_to map_proposals_path, id: "map", title: t("shared.tags_cloud.districts_list") do %> | |||
| <%= image_tag("map.jpg", alt: t("shared.tags_cloud.districts_list")) %> | |||
| <%= image_tag(image_path_for("map.jpg", alt: t("shared.tags_cloud.districts_list")) %> | |||
There was a problem hiding this comment.
I believe there is one bracket missing from this statement.
milovanderlinden
added a commit
to codefornl/consul
that referenced
this pull request
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This closes #3374.
Objectives
Admin users can change map image on
/admin/site_customization/images.This custom image is not rendering in all pages with the map. With this PR we always render custom map image from admin site customization images if it's present.