Fix obsolete respond_with_bip usage
#3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we removed the `best_in_place` gem, this method doesn't exist anymore. We're replacing it with what the method actually does. Note the test doesn't check the poll is correctly updated. We could add a `visit proposal_dashboard_polls_path(proposal)` before checking the "Show results" field, but then we would enter a race condition between this request and the AJAX request. A proper solution would be to provide actual feedback to the user so they know the poll has been updated, and then checking that feedback is present in the tests.
|
Travis build fails due to a bug not related to this pull request. This bug should be fixed when we merge AyuntamientoMadrid#1615 |
voodoorai2000
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
respond_with_bipusage AyuntamientoMadrid/consul#1998Objectives
respond_with_bip, which belonged to a gem we removed