Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify settings seeds #3564

Merged
merged 10 commits into from
Jun 3, 2019
Merged

Simplify settings seeds #3564

merged 10 commits into from
Jun 3, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented May 29, 2019

References

Objectives

  • Remove duplication between seeds.rb and dev_seeds/settings.rb
  • Reduce the number of steps we need to take when we add a new setting

Notes

⚠️ We need to update the documentation regarding what to do when adding a new setting.

@javierm javierm self-assigned this May 29, 2019
@javierm javierm force-pushed the default_settings branch 7 times, most recently from aff792d to 029c721 Compare May 31, 2019 16:07
@javierm javierm mentioned this pull request May 31, 2019
Merged
javierm added 10 commits May 31, 2019 19:27
@javierm
Remove redundant comments
bf6cadd 
Commenting things like "proposal_code_prefix" represents the "Prefix
for the Proposal codes" is unnecessary.
@javierm
Simplify code seeding settings
19245ef
@javierm
Move default settings to Settings model
bac0004
@javierm
Sort settings alphabetically
9e6e6d6
@javierm
Extract method to reset default settings
7830d90
@javierm
Reuse default settings in dev seeds
ced0409
@javierm
Simplify dev seed settings code
3db1acf
@javierm
Use translations for official level names seeds
ff21ce7
@javierm
Use a rounded value for default supports needed
cf26b23 
We were using the value which is used in Madrid.
@javierm
Order settings to follow our traditional order
555fae0 
Settings are displayed in the administration in the order they are
created, and reordering them alphabetically in the code caused them to
be displayed in a different order.

Since we don't want to confuse our users by randomly changing the order,
I've grouped the settings by namespaces and ordered each namespace the
way it used to be.

Note dev seeds don't need to be changed, since they are executed after
default settings have been created.
@javierm javierm merged commit a6c63ac into master Jun 3, 2019
@javierm javierm deleted the default_settings branch June 3, 2019 09:53
@javierm javierm mentioned this pull request Jun 25, 2019
Closed
@javierm javierm mentioned this pull request Nov 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

@decabeza decabeza decabeza approved these changes

@microweb10 microweb10 microweb10 approved these changes

Assignees

@javierm javierm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@javierm @voodoorai2000 @decabeza @microweb10