-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete spending proposals #3569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 30, 2019
voodoorai2000
force-pushed
the
delete_spending_proposals
branch
3 times, most recently
from
May 30, 2019 18:22
b7aa444
to
38548c3
Compare
decabeza
approved these changes
May 31, 2019
voodoorai2000
force-pushed
the
delete_spending_proposals
branch
from
May 31, 2019 13:44
38548c3
to
3dda34e
Compare
voodoorai2000
force-pushed
the
delete_spending_proposals
branch
from
May 31, 2019 16:23
3dda34e
to
7218d80
Compare
javierm
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
PR: #3441
PR: AyuntamientoMadrid#1937
Context
SpendingProposals
where used as theProposals
in Participatory Budgets but have since become deprecated in favor ofBudget::Investments
.Objectives
Delete
SpendingProposals
and all related resources.This PR will remove the tables and code for the following modules:
SpendingProposals
(proposals for a participatory budget)ValuationAssignments
(users who valuate spending proposals)Release Notes
bin/rake settings:remove_deprecated_settings RAILS_ENV=production
Notes
So long and thanks for the old shoes 🙏