Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete spending proposals #3569

Merged
merged 8 commits into from
May 31, 2019
Merged

Delete spending proposals #3569

merged 8 commits into from
May 31, 2019

Conversation

voodoorai2000
Copy link
Member

@voodoorai2000 voodoorai2000 commented May 30, 2019

References

PR: #3441
PR: AyuntamientoMadrid#1937

Context

SpendingProposals where used as the Proposals in Participatory Budgets but have since become deprecated in favor of Budget::Investments.

Objectives

Delete SpendingProposals and all related resources.

This PR will remove the tables and code for the following modules:

  • SpendingProposals (proposals for a participatory budget)
  • ValuationAssignments (users who valuate spending proposals)
  • Counter caches (for spending proposals' tags and valuations).

Release Notes

⚠️ Run this rake task to remove obsolete settings from db:
bin/rake settings:remove_deprecated_settings RAILS_ENV=production

Notes

So long and thanks for the old shoes 🙏

spec/lib/graphql_spec.rb Show resolved Hide resolved
spec/lib/graphql_spec.rb Show resolved Hide resolved
app/models/valuator.rb Outdated Show resolved Hide resolved
app/models/valuator.rb Outdated Show resolved Hide resolved
@voodoorai2000 voodoorai2000 force-pushed the delete_spending_proposals branch 3 times, most recently from b7aa444 to 38548c3 Compare May 30, 2019 18:22
@voodoorai2000 voodoorai2000 added this to Doing in Roadmap May 30, 2019
@voodoorai2000 voodoorai2000 merged commit a3f538a into master May 31, 2019
@voodoorai2000 voodoorai2000 deleted the delete_spending_proposals branch May 31, 2019 17:11
@voodoorai2000 voodoorai2000 moved this from Doing to Review in Roadmap Jun 18, 2019
@voodoorai2000 voodoorai2000 moved this from Review to Release 1.0.0 in Roadmap Jun 18, 2019
@voodoorai2000 voodoorai2000 moved this from Release 1.0.0 to Release 1.0.1 in Roadmap Jun 18, 2019
@voodoorai2000 voodoorai2000 moved this from Release 1.0.1 to Release 1.0.0 in Roadmap Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants