Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new settings automatically on every deployment #3576

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Add new settings automatically on every deployment #3576

merged 2 commits into from
Jun 3, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented May 31, 2019

References

Objectives

  • Remove the need to manually run rake tasks when we add a new setting

@javierm
Add method to add new settings
bb504d9
@javierm
Add new settings every time we deploy
e339ed9 
This way we don't need to add and execute rake tasks every time we add a
new setting.
@javierm javierm changed the base branch from default_settings to master June 3, 2019 09:53
@javierm
Copy link
Member Author

javierm commented Jun 3, 2019

Travis failure is not related to this pull request.

@javierm javierm merged commit 90c1d68 into master Jun 3, 2019
@javierm javierm deleted the new_settings branch June 3, 2019 09:54
@javierm javierm mentioned this pull request Oct 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javierm @voodoorai2000