Responsive translation interface #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 3, 2019
houndci-bot
reviewed
Jun 3, 2019
Senen
force-pushed
the
translations-new-interface
branch
2 times, most recently
from
44d34f4
to
669eb4f
Compare
houndci-bot
reviewed
Jun 6, 2019
Senen
force-pushed
the
translations-new-interface
branch
2 times, most recently
from
c9ec0d6
to
9cb88fc
Compare
Senen
changed the title
javierm
force-pushed
the
translations
branch
3 times, most recently
from
8515533
to
43c5a69
Compare
taitus
force-pushed
the
translations-new-interface
branch
from
823dc5b
to
a6fc116
Compare
houndci-bot
reviewed
Jun 12, 2019
taitus
force-pushed
the
translations-new-interface
branch
from
d063d9b
to
a50281f
Compare
Senen
force-pushed
the
translations-new-interface
branch
from
b801364
to
373d20e
Compare
houndci-bot
reviewed
Jun 12, 2019
spec/features/admin/site_customization/information_texts_spec.rb
Outdated
Show resolved
Hide resolved
Senen
force-pushed
the
translations-new-interface
branch
2 times, most recently
from
f5025ce
to
706cd2a
Compare
voodoorai2000
force-pushed
the
translations
branch
from
5aad211
to
251326e
Compare
As we are going to call this partial from any application view it will have more sense to place it at `app/views/shared`.
Co-Authored-By: alessandro <agileontheweb@gmail.com>
Only when translations interface is enabled. Co-Authored-By: alessandro <agileontheweb@gmail.com>
…lations interface
Add new js method to recover selected language to disable correctly default language fields.
We understand languages management as the ability to add new languages or remove existing ones. When no option is passed it will allow language manipulation by default. There are 3 special places where we want block languages management: - admin legislation processes homepage - admin legislation processes milestones summary - proposals retired form Co-Authored-By: Sebastia <sebastia.roig@gmail.com>
After extract translation interface partials from admin folder translations should be placed in general.yml file inside shared context.
This file was used at previous version of translation interface.
Senen
force-pushed
the
translations-new-interface
branch
from
706cd2a
to
b0004a6
Compare
Senen
force-pushed
the
translations-new-interface
branch
from
b0004a6
to
12d20b4
Compare
voodoorai2000
approved these changes
Jul 5, 2019
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…new-interface Responsive translation interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related Issues: #3130
Objectives
Provide users a responsive interface to manage translations.
New interface uses two native select elements to allow the user to choose a language from existing ones, and the other selector is to add new languages. User can remove languages through a "DEstroy language" link, same as previous interface.
This new interface is responsive and could be nicely shown at mobile devices and translatable fields are highlighted with a blue background to easily distinguish them from fields that are not.
Also a new option
manage_languagesto block adding and removing languages was added to cover special cases where we cannot allow the user to remove or to add new languages. An example of a place with this special needs is the proposals retire form.This new interface was applied to following admin pages:
This new interface was also applied to following public pages:
Visual changes
Before
Interface with tabs. Mobile version
Interface with tabs. Desktop version
After
Responsive interface
Highlighted translatable fields
Proposal form with translation interface enabled. Desktop Version
Proposal form with translation interface enabled. Mobile Version
Language managment blocked: Proposal retire form with translation interface enabled. Mobile Version
Notes
None